refactor(client): add _url & _ajax_url helper methods#384
refactor(client): add _url & _ajax_url helper methods#384Danipulok wants to merge 5 commits intoupbit:masterfrom
_url & _ajax_url helper methods#384Conversation
|
There are significant differences in the interfaces and fields between |
|
Got it, thanks for claryfying. There's already a method that uses Web API (showcase). So the idea is that if it's already used (I did not add it) is to make it kinda more generic What about the methods like comments from my other PR that returns 404 now? And that method with |
|
@upbit please tell me what you think about adding just |
# Conflicts: # pixivpy3/aapi.py
Both |
|
@upbit I have removed the |
# Conflicts: # pixivpy3/aapi.py
|
@upbit I have updated the PR. Please review |
What this PR does?
_urland_ajax_urlhelper methods to the class to omit boilerplate formatting;TODO:
After this PR is merged (I hope), I would like to make all constants actual constants. It will allow us to reuse code and have it in one place even more